Repository navigation
OpenConceptLab/ocl_online#488 | Skip follows with no object, and load a user's pins only for that user or staff - #101
Merged
Merged
Conversation
… a user's pins only for that user or staff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares TBv3 for OpenConceptLab/oclapi2#990 (OpenConceptLab/ocl_online#488). Deploy this before #990 reaches production.
object: null. The left menu and the profile's Following list now skip them instead of crashing onfollowed.url./users/<u>/pins/answers only that user and staff (401 anonymous, 403 others). The profile page now loads a user's pins only for that user or staff. Before, an anonymous visitor's 401 started the renew-or-sign-out path and sent them to sign in. Org pins are unchanged.Not in this PR: an unfollow for follows of objects the user can no longer view. The API allows it now (
DELETE /users/<u>/following/<id>/), but TBv3 has no list to offer it from yet.Tests:
npm test(146 pass, including new tests for both rules); ESLint clean on the changed files.🤖 Generated with Claude Code