Fix false empty entry in custom submenus - #2551
Merged
ge0rdi merged 1 commit intoOct 5, 2026
Merged
Conversation
YellowNest
added a commit
to YellowNest/Open-Shell-Menu
that referenced
this pull request
Oct 4, 2026
Bundle current master with pending PRs Open-Shell#2547, Open-Shell#2548, Open-Shell#2551, Open-Shell#2552, and Open-Shell#2553 for local integration testing. This branch is test packaging only and is not intended for upstream merge.
ge0rdi
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid inserting the
(Empty)placeholder into custom submenus before their configured child items are appended.For a custom item that points to a link and also has configured submenu children,
InitItems()could addMENU_EMPTYimmediately after shell enumeration returned no items.AddStandardItems()then appended the configured child items and inserted a separator because the menu was no longer empty, resulting in:(Empty)separator
configured submenu item
Submenus now defer the empty-state decision until after custom/standard items have been appended. The existing top-level drop-target placeholder behavior is preserved.
Verification
Buildpassed for exact commit479d3b15792acafdb78cf063934e4ca4ec1f307d.CMenuContainer::InitItems().m_Items.empty()check afterAddStandardItems().Build:
https://github.com/YellowNest/Open-Shell-Menu/actions/runs/37220700506
Fixes #2543