Repository navigation
feat(navigator): show player limits in the blue titan palette - #423
Closed
TheMeinerLP wants to merge 2 commits into
Closed
TheMeinerLP wants to merge 2 commits into
TheMeinerLP wants to merge 2 commits into
Conversation
Contributor
Test results 894 files 894 suites 41m 17s ⏱️ Results for commit e20e57e. |
Contributor
Author
|
Superseded by #450: the navigator now shows online/max and uses per-mode gradients chosen in the navigator refresh. A palette-only change can be reopened on top of main if wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #419 (fix/navigator-task-names); merge that first, or retarget this PR once #419 lands.
Changes
current/max(e.g.12/100) instead ofN online. When the provider reports no max (0) only the current count is shown; an unknown count still adds no line.TaskPlayersreturns the task'sPlayerCount(online and max, summed over running services) instead of a bare int.PlayerCountalready carriedmax, so no core/common/bridge type changed.Tests
DestinationPlayerLoreTest: current/max, current only (max 0), zero, gray slash, unknown adds no line.TaskPlayersTest,NavigatorPlayerCountTest: switched to thePlayerCountAPI andN/100lore.NavigatorDestinationTest: Slender letter colors now #00b4d8 to #caf0f8.NavigatorModuleTest: spawn name compared as plain text, since its color changed.https://claude.ai/code/session_01GXose9rakuRNZoM3TP3xj1