Repository navigation
fix(jumprun): debounce the mode switch and accidental stops - #421
Merged
Merged
Conversation
Contributor
Test results 447 files 447 suites 26m 21s ⏱️ Results for commit af01085. ♻️ This comment has been updated with latest results. |
TheMeinerLP
force-pushed
the
fix/jumprun-mode-switch-debounce
branch
from
October 12, 2026 21:02
173d5e4 to
177c3f8
Compare
TheMeinerLP
force-pushed
the
fix/jumprun-mode-switch-debounce
branch
from
October 17, 2026 16:36
177c3f8 to
350f907
Compare
The mode tests ended runs with the module's toggle, so nothing exercised the use path they are about. They now end and switch through the lobby item after the grace period. The tick loops and the random UUID of the leaver test move to the fixture, which now has tick and tickPastGrace. Claude-Session: https://claude.ai/code/session_01DWzXyozSMX1ngvbMZGLvwA
A block placement only suppresses the follow-up use while a run is going on. Between runs the use after a click on a lobby block starts the run or switches the mode, as the item itself would. Ending a run now clears its start grace and pending click state whatever ended it, so a restart right after a death or a return to spawn is not refused. Four new click tests failed on their assertions before this change. Claude-Session: https://claude.ai/code/session_01DWzXyozSMX1ngvbMZGLvwA
The mode switch debounce and the start grace of a run contradict the sneak-click and item-toggle requirements of lobby-jumprun. The delta states the 5 tick mode window, the 20 tick start grace, the 2 tick follow-up of a block click during a run, and that the grace ends with the run. Claude-Session: https://claude.ai/code/session_01DWzXyozSMX1ngvbMZGLvwA
TheMeinerLP
force-pushed
the
fix/jumprun-mode-switch-debounce
branch
from
October 25, 2026 09:10
350f907 to
af01085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root causes
use()toggles, so a double click or the follow-up use packet of a click on a real lobby block stopped the run.Fix
suppressedUntilmechanism.env.tick().Spec
OpenSpec change
openspec/changes/jumprun-click-debounce(proposalfix(jumprun)). Its delta MODIFIES the requirements "Schwierigkeitsmodi" (every sneak click switches the mode, except within the 5-tick window after a switch) and "Laufende" (the item ends a run, except within the 20-tick start grace; block clicks during and outside a run), each with scenarios. The change is validated; its tasks are checked, and the last one is this PR.Tests
useItem, sneak use) instead of the module's toggle, so they exercise the use path.fixture.tick/fixture.tickPastGrace, a fixed UUID in the leaver test../gradlew spotlessApplyand./gradlew buildare green locally.https://claude.ai/code/session_01DWzXyozSMX1ngvbMZGLvwA