Skip to content

chore(map): prepare map handling to allow voting - #446

Merged
theEvilReaper merged 2 commits into
mainfrom
feat/map-catalog
Oct 29, 2026
Merged

theEvilReaper merged 2 commits into
mainfrom
feat/map-catalog

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

The game only runs on one map at the moment, but there is a possibility that more maps could be added in the future. The current implementation of the AbstractMapProvider isn't designed to handle voting or even a simple random map selection. This pull request prepares the provider to support a map pool and randomly select a map from it. In a later step, we can reuse this to implement map voting.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper added this to the v2.21.0 milestone Oct 29, 2026
@theEvilReaper theEvilReaper self-assigned this Oct 29, 2026
@github-actions github-actions Bot added the area: game Everything related to the the game module label Oct 29, 2026
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Test results

  885 files    885 suites   8m 47s ⏱️
2 340 tests 2 338 ✅ 2 💤 0 ❌
7 020 runs  7 013 ✅ 7 💤 0 ❌

Results for commit dad576f.

♻️ This comment has been updated with latest results.

@theEvilReaper
theEvilReaper merged commit 5912c6d into main Oct 29, 2026
13 of 14 checks passed
@theEvilReaper
theEvilReaper deleted the feat/map-catalog branch October 29, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant