Skip to content

feat(game): add page pickup sound and fix hit sounds - #444

Merged
theEvilReaper merged 2 commits into
mainfrom
feat/hit-and-page-sounds
Oct 29, 2026
Merged

theEvilReaper merged 2 commits into
mainfrom
feat/hit-and-page-sounds

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

The game doesn't play any sound when a survivor picks up a page. In general, this isn't a problem, but a small indication sound would be great here. With #419, the Slender player gets sounds when a hit was missed, which was a bit misleading. This pull request adds a sound that is played when someone finds a page. The Slender player only hears hit sounds when a target in range actually gets damaged.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@github-actions github-actions Bot added the area: game Everything related to the the game module label Oct 29, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Test results

  879 files    879 suites   8m 38s ⏱️
2 329 tests 2 327 ✅ 2 💤 0 ❌
6 987 runs  6 980 ✅ 7 💤 0 ❌

Results for commit cda23e1.

♻️ This comment has been updated with latest results.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@theEvilReaper
theEvilReaper merged commit ee8f249 into main Oct 29, 2026
13 of 19 checks passed
@theEvilReaper
theEvilReaper deleted the feat/hit-and-page-sounds branch October 29, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant