Skip to content

feat: add share button for comparison results - #218

Merged
O2sa merged 3 commits into
O2sa:mainfrom
NRR385:feat/share-compare-results
Oct 3, 2026
Merged

O2sa merged 3 commits into
O2sa:mainfrom
NRR385:feat/share-compare-results

Conversation

@NRR385

@NRR385 NRR385 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a share button to comparison results
  • Use the Web Share API when available with clipboard fallback
  • Preserve comparison URL parameters, including selected languages
  • Add English and Arabic share labels and feedback

Testing

  • pnpm run test — 131/131 tests passed
  • npx tsc --noEmit — passed
  • pnpm run validate-locales — passed
  • pnpm run lint — passed
  • Manually tested native sharing and shared URL reload
  • Manually verified English and Arabic UI

Closes #191

@vercel

vercel Bot commented Oct 3, 2026

Copy link
Copy Markdown

@NRR385 is attempting to deploy a commit to the osama's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown

Thank you for the pull request! ✅

A maintainer will review this soon. Please be patient while we take a look. 🙌

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dev-impact Ready Ready Preview Oct 3, 2026 8:59pm UTC

@O2sa
O2sa merged commit 8d7f385 into O2sa:main Oct 3, 2026
4 checks passed
@O2sa

O2sa commented Oct 3, 2026

Copy link
Copy Markdown
Owner

🎊 Welcome, @NRR385! Your first contribution has been merged! 🚀

Thank you for helping improve the project! If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work and motivates us to keep improving!

This branch was successfully deployed

1 active deployment
Preview — 2cddf626 Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Add share button for compare results

2 participants