Repository navigation
build: Clear the last warning and build with -warnaserror - #34
Merged
henrikottesorensen merged 2 commits intoOct 9, 2026
Merged
Conversation
CA1861 flagged the inline array in FindImport_FindsFreeInTheLiblouisWeShip, the only analyzer warning left in the build (once per target framework). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the CA1861 warning gone the build is warning free, so keep it that way: the CI test job and build_managed_packages.sh, which builds what gets packed and published, now fail on any warning. The native runtime packages are left alone. Their dotnet pack only wraps prebuilt binaries, and its NuGet warnings (no readme) would fail it for nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
henrikottesorensen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the managed build warning free and keeps it that way.
Changes
new[] { "msvcrt.dll", "ucrtbase.dll" }inLiblouisHeapTests.FindImport_FindsFreeInTheLiblouisWeShip, once per target framework. It came in with Fix/pinvoke review feedback #33. The array moves to astatic readonlyfield, with a comment saying which runtime belongs to which toolchain. There's no behaviour change.-warnaserror. Two places now fail on any warning:testjob'sdotnet testbuild/build_managed_packages.sh'sdotnet build, which builds the packages that get publisheddotnet packonly wraps prebuilt binaries, and its NuGet "missing readme" warnings would fail it for no benefit.Testing
-warnaserrorsucceed with 0 warnings, for bothLibLouis.NET.slnx(including the library's pack-on-build) and the test project.Effect on open PRs
#20 to #22 had no other warnings when I last built them on top of #32. Once this merges they'll need a rebase, and any warning they add will fail CI.
🤖 Generated with Claude Code