Skip to content

Render user bios as sanitized Markdown - #616

Open
BaseMax wants to merge 7 commits into
NextCommunity:mainfrom
MaxFork:max-updates-safe-markdown-bio
Open

BaseMax wants to merge 7 commits into
NextCommunity:mainfrom
MaxFork:max-updates-safe-markdown-bio

Conversation

@BaseMax

@BaseMax BaseMax commented Sep 25, 2026

Copy link
Copy Markdown
Member

Fixes #403. User bios are now rendered as sanitized Markdown instead of escaped plain text, so bold, italic, links, lists and code work in a bio's YAML field.

@deepsource-io

deepsource-io Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 6e080c5...1056e42 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Sep 26, 2026 1:02a.m. Review ↗
Secrets Sep 26, 2026 1:02a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@jbampton jbampton self-assigned this Sep 25, 2026
@BaseMax

BaseMax commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

@jbampton ready for you.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The lockfile is out of sync, and homepage bio excerpts do not consistently render the new Markdown format.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

This PR adds sanitized Markdown rendering for user bios, updates documentation and styling, and preserves plain-text SEO output.

Changes:

  • Adds markdown-it filters for Markdown and plain text.
  • Converts Ken Horlador’s bio to Markdown.
  • Styles rendered bio content and documents supported syntax.
  • Adds the Markdown dependency.
File Summary
src/​users/​kenhorlador.yaml Converts bio formatting to Markdown; directory excerpts still need consistent plain-text handling.
src/​assets/​css/​style.css Styles rendered Markdown elements; heading reset should include h4–h6.
src/​_includes/​layouts/​base.njk Uses plain-text bio content for SEO descriptions.
src/​_includes/​bio.njk Renders bios as sanitized Markdown.
README.md Documents Markdown bio syntax.
package.json Adds markdown-it; the lockfile root dependency entry must also be updated.
.eleventy.js Registers Markdown and plain-text filters.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
"js-yaml": "^5.4.2",
"lightningcss": "^1.33.0",
"magic-string": "^1.4.1",
"markdown-it": "^14.2.0",
Comment thread src/_includes/bio.njk
Comment on lines +72 to +73
<div class="text-[var(--text-main)] text-lg leading-relaxed bio-content">
{{ bio | markdown | safe }}

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

use of HTML tags like inside a YAML

3 participants