Repository navigation
D237 — a failed module check says its tool's last lines and keeps its whole output - #433
Merged
Merged
Conversation
… whole output Closes #428. Agent-Session: nstack-os-d237 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-admin
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #428.
Why
On #428's project, a test failed under
nstack attest, and the only output wasFAIL [test] module 'shell': `cargo test --locked …` exited with 101. Run again by hand, the test passed: it was flaky, and its name was lost, so there was nothing to quarantine or to file. To get the name the next time, the team put acargoshim on the attest's PATH.What
attestshows the last lines (8) the module's own command wrote before it exited. A test runner's summary (cargo, pytest, Go) names the failed test there.-> <module>: <command>.Evidence of …), whose lines are the engine's, not the tool's..git/nstack/attest/<commit>-<check>.log, or the worktree's own git folder in a worktree. Its path is printed under the FAIL line.07-governance.md§7 says it. Register row D237.Tests
test_a_failed_module_check_says_its_tool_s_last_lines_and_keeps_its_output(red on main): a cargo-like failure with 400 lines of noise.test_a_passed_check_leaves_no_log.test_each_module_s_failure_says_its_own_tool_lines_and_never_the_engine_s:test_a_step_that_prints_bytes_not_utf_8_is_recorded(red on main).--path-format=absoluteon git older than 2.31 wrote the log into the tree;::errorannotations are not counted as the tool's lines.🤖 Generated with Claude Code