Repository navigation
D236 — a push refused with the hold unmoved is said as refused, with its reason - #432
Merged
Merged
Conversation
…its reason Closes #427. Agent-Session: nstack-os-d236 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-admin
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #427.
Why
On #427's project, the default branch was red on B1 and the pre-push fitness hook refused every push.
nstack unclaimsaid twice « hold moved meanwhile … run nstack plan, then again », although the hold was the same locally and on the remote. Runningnstack planand trying again could never help. The hook's own reason, written on stdout, was lost, because_recordkept stderr alone.What
flowchart LR P[push of a hold's event refused] --> F{read the remote again} F -->|another event came first| M[hold moved meanwhile: today's message] F -->|same tip as before| R[the push was refused, the hold did not move:<br/>the refusal's words, what can refuse] F -->|this very event is there| OK[recorded: git failed after the remote took it] F -->|unreadable| U[refused; whether it moved is not known]Legend: what
claim,unclaimanddeliversay after a refused push.hold.py:_after_refusaland_refusalare shared by all three commands._recordquotes both output streams..nstack/fitness-before-push.sh(D232's script) lets nstack's own records through without judging:refs/heads/nstack/hold/…;refs/notes/nstack/….They move no file of the project. Every other hook still runs, and CI judges every pull request.
Register row D236.
Tests
unclaim);deliverand forclaim.test_push_hook.py: a hold's branch and nstack's notes are let through;nstack/hold-not-a-holdandmainare still judged.PRE_COMMIT_REMOTE_BRANCHitself._pre_push_ns(deletions never set the variable) and checked the tip comparison on every release path. Its findings are fixed:refs/notes, were stopped by the hook the same way;claim's wording was untested.🤖 Generated with Claude Code