Repository navigation
D235 — the tests hold the engine's clock at the day the run started - #431
Merged
Merged
Conversation
Agent-Session: nstack-os-d235 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-admin
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
D228's oracle started on 2026-11-17 and finished on 2026-11-18. Seven tests of
test_plan.pyfailed because of the date, not because of any rule; run again, they passed.test_plan.pycomputesTODAYonce, when the module loads, and buildsparametrizearguments from it. The engine reads the clock at each call. A run that crosses midnight therefore puts the two a day apart.What
platform/tests/conftest.py: an autouse fixture holds the engine's clock at the day the run started,RUN_DAY.fitness/plan,fitness/manifestsandpull_request.date.today()is held;datetime.datetimestays real.todaywould still move under them.Tests
test_the_accepted_cycle_says_its_progress_in_one_line;test_a_dropped_deliverable_counts_in_nothing_and_a_state_absent_is_not_said;test_a_cycle_past_its_end_says_the_circuit_breaker;test_a_cycle_not_started_says_when_it_starts;test_the_end_date_is_the_first_day_over[last day];test_one_day_is_said_in_the_singular×2.🤖 Generated with Claude Code