Repository navigation
D234 — CI audits the framework's lock for known vulnerabilities - #426
Merged
Merged
Conversation
Agent-Session: nstack-os-d234 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rned, the auditor out of dev Agent-Session: nstack-os-d234 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-admin
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Security tab showed 32 Dependabot alerts on
filelock3.32.6 andvirtualenv21.7.9. Both are transitive dependencies ofpre-commit, and both had been fixed upstream since October. Nothing raised them for three reasons:pyproject.tomldeclares.#425 moved the lock past these versions. This pull request keeps it from happening again.
What
flowchart LR L[uv.lock] -->|uv export: what uv sync installs, hashed| R[locked.txt] R -->|pip-audit -f json| J[report] J --> V{platform/audit_lock.py} V -->|a release fixes it| X[Hooks and secrets: red] V -->|no fix yet| W[warning on the check, green] V -->|not audited, no report| X V -->|none| G[green] D[Dependabot security updates] -->|pull request moving the lock| LLegend: what CI runs, last in
Hooks and secrets; Dependabot opens the fix.governance.yml, jobHooks and secrets: one new step, the job's last, so a red there never hides the secrets and messages checks. It is a step, not a job, so the ruleset's required checks are unchanged.platform/audit_lock.pyjudges pip-audit's JSON report:uv lock --upgrade-package <name>;pip-audit==2.10.1sits in its ownauditgroup. Dependabot keeps it current, and nouv syncinstalls it or its 25 packages. The audit reads whatuv sync --lockedinstalls, the default groups.SECURITY.md: what fails, what warns, and who opens the fix. Dependabot's security updates are outside the cooldown and the weekly grouping. The published package carries no lock.run.shproves the verdict offline, on reports it writes: fixed → fails; unfixed → warning and passes; empty, not JSON, or skipped → fails; clean → passes. It also checks that the step stays last and is nevercontinue-on-error.Tests
filelock==3.32.6: FAIL with CVE and fix named, rc=1. The lock before Lock: filelock 4.2.10, virtualenv 21.15.6, python-discovery 1.9.5 — 32 advisories #425 gave 32./code-review mediumfindings taken:dev;--all-groupsaudited more than what is installed;🤖 Generated with Claude Code