Repository navigation
Add the Eurotherm (eurotherm), copied from nslsii#264 - #11
Merged
Anthony Sligar (sligara7) merged 1 commit intoOct 23, 2026
Merged
Anthony Sligar (sligara7) merged 1 commit into
Anthony Sligar (sligara7) merged 1 commit into
Conversation
pdftools.eurotherm3k copies nslsii#264 (26efeef) and its tests, reformatted to pdftools' line length only (same syntax tree). It is used until #264 merges; then the profile imports it from nslsii.ophyd_async.devices and this module goes. The profile builds eurotherm on XF:28ID1-ES{ET:05}, the eurotherm3k IOC on xf28id1-ioc2; the old eurotherm3504 is loop1. A test pins its PV names to the old profile's record list.
Assisted-by: copilot:claude-opus-5-5
Anthony Sligar (sligara7)
merged commit Oct 23, 2026
d53ec7e
into
NSLS2:pdf-profile-conversion
4 checks passed
There was a problem hiding this comment.
🟡 Changes recommended
The recipe-selection PV pairing prevents real connection, and stalled setpoint writes can bypass the move timeout.
2 open issues
What changed in this PR
Adds the PDF Eurotherm 3504 controller to the collection profile using a temporary local copy of the device implementation from NSLS2/nslsii#264.
Changes:
- Adds a two-loop controller with temperature movement and settling support.
- Exposes
eurothermin the profile, withloop1corresponding to the legacy device. - Adds mock behavior, PV mapping, and profile startup tests.
| File | Description |
|---|---|
tests/test_utils.py |
Checks that mock profile startup exposes eurotherm. |
tests/test_eurotherm3k.py |
Tests device signals, movement, settling, and legacy PV mappings. |
tests/test_eurotherm_pvs.py |
Checks PV addresses against the old profile. |
src/pdftools/profiles/collection.py |
Instantiates the beamline Eurotherm controller. |
src/pdftools/eurotherm3k.py |
Adds the temporary controller implementation. |
Review effort: Balanced
| new_position, | ||
| self.readback, | ||
| in_band, | ||
| timeout=timeout(), |
Comment on lines
+145
to
+147
| recipe_select: A[ | ||
| SignalRW[str], PvSuffix.rbv("RECSEL", ":RBV"), Format.CONFIG_SIGNAL | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
eurotherm = Eurotherm3k("XF:28ID1-ES{ET:05}")to the profile: the PDF Eurotherm 3504, aneurotherm3kIOC on xf28id1-ioc2. The oldeurotherm3504iseurotherm.loop1.pdftools/eurotherm3k.pyandtests/test_eurotherm3k.pyare copied from Add Eurotherm3k ophyd-async device (HXM-1305) nslsii#264 (26efeef), reformatted to pdftools' line length only (same syntax tree; class-docstring lint waived for this file). Temporary: once #264 merges, import it fromnslsii.ophyd_async.devicesand delete the copy.16-eurotherm_HAB.py.Verified: mock tests (the nslsii device tests, PV names, profile boots in mock mode with
eurotherm). Not run on the beamline.