Repository navigation
fix(deps): bump glibc to 2.28 and pin nodejs to 22.23.4 - #58
Closed
Padraic Shafer (padraic-shafer) wants to merge 1 commit into
Closed
Padraic Shafer (padraic-shafer) wants to merge 1 commit into
Padraic Shafer (padraic-shafer) wants to merge 1 commit into
Conversation
The linux-64 platform was pinned to glibc = "2.17", which only
supports Node.js up to v20. All CDI workstations run RHEL 8+
(glibc >= 2.28), so the glibc floor can be safely raised.
Following the NSLS2/ansible server_env precedent (commit 6b3e51619),
bumped glibc to 2.28 and added an explicit nodejs floor constraint
to the feature.dev.dependencies (where pyright, the nodejs consumer,
lives) to enforce the v22 LTS line minimum.
pixi.lock must be regenerated before merging:
pixi lock
Refs: https://nodejs.org/en/blog/vulnerability/july-2025-security-releases
Assisted-by: opencode:claude-opus-4-8
Assisted-by: opencode:claude-sonnet-4-6
There was a problem hiding this comment.
🟢 Approval recommended
The focused manifest changes match the intended platform requirements and checked lockfile entries, with no unresolved findings.
No open issues 🎉
What changed in this PR
Updates the Pixi environment’s Linux baseline to glibc 2.28 for RHEL 8+ workstations and constrains Node.js to version 22 for development tooling.
Changes:
- Names the Linux platform
linux64-glibc228and raises its glibc requirement from 2.17 to 2.28. - Adds
nodejs = ">=22.23.4,<23"alongside pyright in development dependencies.
| File | Description |
|---|---|
pixi.toml |
Updates the Linux platform definition and adds the Node.js 22 dependency range. |
Review effort: Balanced
Contributor
Author
|
Putting this in draft, possibly to effectively merge this PR into https://github.com/NSLS2/cditools/pull/57/changes |
Padraic Shafer (padraic-shafer)
marked this pull request as draft
October 26, 2026 17:21
Padraic Shafer (padraic-shafer)
requested a review
from Thomas A Caswell (tacaswell)
October 26, 2026 17:28
Contributor
Author
|
Superseded by commit to #57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The linux-64 platform was constrained to
glibc = "2.17", limiting Node.js to v20. CDI workstations run RHEL 8+ (glibc ≥ 2.28). Following the NSLS2/ansible server_env precedent, bumped glibc to 2.28 (using the named-platform form required by pixi ≥ 0.83) and added a nodejs v22 floor where pyright (the nodejs consumer) lives.pixi.tomlplatformglibc = "2.17"→{ name = "linux64-glibc228", platform = "linux-64", glibc = "2.28" }pixi.tomldepsnodejs = ">=22.23.4,<23"to[feature.dev.dependencies]pixi.lockRefs: https://nodejs.org/en/blog/vulnerability/july-2025-security-releases