Skip to content

revert: remove highlightPeak bridge pending controllable NMRium API - #316

Open
vcnainala wants to merge 1 commit into
developmentfrom
revert/highlight-peak-bridge
Open

vcnainala wants to merge 1 commit into
developmentfrom
revert/highlight-peak-bridge

Conversation

@vcnainala

Copy link
Copy Markdown
Member

Summary

  • Reverts feat: add highlightPeak action-request for host-driven peak highlighting #315 (2193ddf) so we no longer reach into NMRium's private highlight module via a Vite resolveId redirect.
  • Host-driven peak highlighting will come back once NMRium exposes a public controllable highlight / onHighlightChange API; the wrapper will then map highlightPeak / clearHighlight onto that API without module aliasing.

Test plan

  • Confirm src/highlight/ is gone and vite.config.ts / tsconfig.json no longer reference nmrium-highlight-original
  • npm run check-types
  • Existing e2e suite still passes (highlight-peak test is removed with the revert)
  • Embedding hosts that sent highlightPeak / clearHighlight get a console error for unknown action type and otherwise keep working

…tion-request"

This reverts commit 2193ddf, reversing
changes made to ffb97b5.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant