Repository navigation
Identify ourselves in document fetches [production] - #498
Merged
Merged
Conversation
… where we don't retry on intermittent 500
eyeseast
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an environment variable where we can configure our user agent when we fetch file by URL instead of it being a generic python-requests user agent which is increasingly being blocked
Fixes a latent bug in fetch_file_url that did not retry on 500+ status codes. exc.response is falsy for status codes 400+, so it would never retry on 500. This is because the bool representation of a response with a status code of 400+ is by default False so the rest of the evaluation would become False.
I think what this was going for is making sure that exc.response is not None to act as a guard. I added a test to make sure we do retry on 500 codes, which is the spirit of the retry logic there. When I reverted back to if (exc.Response
it failed the test.
Closes #414
Testing:
I deployed it to staging and confirmed the user agent defined in settings loads and is correctly used when fetch_url is called.