Conversation
Refine _apply_media to distinguish three cases: - compounds matched: open those exchanges - compounds present but no match: warning, leave default bounds - zero compounds (Empty media): close all exchanges Add regression tests in tests/unit/test_load_media_and_apply_media.py covering all three cases plus _load_media empty-compound handling. Fixes ModelSEED/modelseed-api-ops#34
jplfaria
force-pushed
the
auto-triage/empty-media-valueerror
branch
from
September 29, 2026 19:51
b9d893e to
89d23e9
Compare
Contributor
Author
|
Superseded by a9b7a72, which fixes Empty-media handling in both Celery and subprocess FBA paths, preserves malformed-payload errors, and includes regression coverage. That commit is deployed and production biological acceptance passed: https://github.com/ModelSEED/modelseed-api/actions/runs/36621735683 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ModelSEED/modelseed-api-ops#34
Root cause
The Empty workspace object at /chenry/public/modelsupport/media/Empty intentionally has zero mediacompounds, meaning all exchanges closed. The _apply_media function was treating empty media identically to the no-match case, leaving default exchange bounds instead of closing all exchanges.
Test plan
Generated with Claude Code