Repository navigation
GEOPY-2952: Cleanup after GEOPY-1602 - #63
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The cleanup is consistent with the current CellObject contract and introduces no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Removes obsolete validation after updated CellObject vertex guarantees.
Changes:
- Removes a redundant
vertices is Nonecheck from cell-data interpolation.
| File | Description |
|---|---|
surface_apps/iso_surfaces/utils.py |
Simplifies cell-centroid calculation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
benk-mira
previously approved these changes
Oct 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #63 +/- ##
===========================================
+ Coverage 84.95% 85.59% +0.63%
===========================================
Files 5 5
Lines 246 243 -3
Branches 30 29 -1
===========================================
- Hits 209 208 -1
+ Misses 22 21 -1
+ Partials 15 14 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2952 - Cleanup after GEOPY-1602