Skip to content

GEOPY-3106: Optimize tiling for large EM inversions - #498

Merged
domfournier merged 11 commits into
developfrom
GEOPY-3106
Oct 21, 2026
Merged

domfournier merged 11 commits into
developfrom
GEOPY-3106

Conversation

@domfournier

@domfournier domfournier commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

GEOPY-3106 - Optimize tiling for large EM inversions

Copilot AI balanced review requested due to automatic review settings October 19, 2026 16:14
@github-actions github-actions Bot changed the title GEOPY-3106 GEOPY-3106: Optimize tiling for large EM inversions Oct 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Label grouping introduces a scalability regression, and source-wire refinement lacks targeted regression coverage.

2 open issues
What changed in this PR

This PR optimizes EM inversion tiling by separating receiver and source-wire mesh refinement.

Changes:

  • Uses 3D distance-based refinement around source wires.
  • Excludes line-current coordinates from receiver-based refinement.
  • Groups ground-TEM receivers by combined part and transmitter labels.
File Description
simpeg_drivers/​utils/​surveys.py Excludes line-current source locations from survey locations.
simpeg_drivers/​utils/​nested.py Separates wire refinement and supports multi-column tiling labels.
simpeg_drivers/​components/​data.py Combines part and transmitter IDs for ground-TEM tiling.

Review effort: Balanced

Comment thread simpeg_drivers/utils/nested.py
Comment thread simpeg_drivers/utils/nested.py Outdated
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.51%. Comparing base (31c9e5b) to head (d0e2984).

Files with missing lines Patch % Lines
simpeg_drivers/components/data.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #498      +/-   ##
===========================================
- Coverage    90.51%   90.51%   -0.01%     
===========================================
  Files          111      111              
  Lines         7140     7155      +15     
  Branches       887      890       +3     
===========================================
+ Hits          6463     6476      +13     
- Misses         456      457       +1     
- Partials       221      222       +1     
Files with missing lines Coverage Δ
simpeg_drivers/utils/nested.py 95.47% <100.00%> (+0.16%) ⬆️
simpeg_drivers/utils/surveys.py 93.45% <100.00%> (+0.12%) ⬆️
simpeg_drivers/utils/synthetics/options.py 100.00% <100.00%> (ø)
simpeg_drivers/components/data.py 94.97% <66.66%> (-0.95%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier
domfournier merged commit 5d4ecfe into develop Oct 21, 2026
20 of 21 checks passed
@domfournier
domfournier deleted the GEOPY-3106 branch October 21, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants