Repository navigation
Devops 1154: address warnings upon publishing Python packages from GitHub - #216
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to transition PyPI publishing from token-based uploads inside reusable workflows to an OIDC “trusted publishing” approach by introducing a composite action and removing the direct pypa/gh-action-pypi-publish steps from the reusable workflows.
Changes:
- Removed the “Publish package to PyPI” step from two reusable workflows that previously published to PyPI/TestPyPI.
- Added a new composite action (
reusable-python-publish_to_pypi) intended to publish distributions to PyPI/TestPyPI via trusted publishing, supporting artifact or release-asset sources.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/reusable-python-release_pypi_assets.yml |
Removes the PyPI/TestPyPI publish step from the release-asset publishing workflow. |
.github/workflows/reusable-python-publish_pypi_package.yml |
Removes the PyPI/TestPyPI publish step from the package publish workflow. |
.github/actions/reusable-python-publish_to_pypi/action.yml |
Adds a composite action to publish to PyPI/TestPyPI using OIDC trusted publishing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
504ca60 to
3feab80
Compare
|
|
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
suggestion: have 2 different simpler actions instead of bundling 2 uses-case into one action
487c01c to
b71cded
Compare
|
|
RomFloreani
changed the title
- Disable auto build-info publish in setup-jfrog-cli (403 + missing .git warnings) - Point conda publish/release jobs to DEVOPS-1154 action (setup-jfrog-cli v5.2.0, removes Node 20 warning)
DEVOPS-1154 - address warnings upon publishing Python packages from GitHub
testing with MiraGeoscience/simpeg#166