ci: run deploys one at a time - #51
Merged
Merged
Conversation
Merging several PRs back to back started parallel deploys into the same DocumentRoot. One run's post-deploy step moved csp-hashes.conf while another run still needed it, so two of six runs on 16.09. failed. A concurrency group now queues them. Running deploys are not cancelled, an interrupted upload would leave a half-updated site.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging several PRs back to back starts one deploy per merge, and those ran in parallel against the same DocumentRoot. On 16.09. six Dependabot merges produced six parallel runs. Two of them failed because another run's post-deploy step had already moved
csp-hashes.confout of the DocumentRoot. The last run was green and the site is fine, but a stale upload finishing last could just as well have won.This adds a concurrency group to
deploy.yml:cancel-in-progress: false, so a running upload is never interrupted halfwayOnly the workflow file changes. Merging this triggers a normal deploy of the current
main.