Fix ISOMIP+ initial state and top drag coefficient - #998
Merged
Merged
Conversation
Newer xarray no longer accepts a Dataset as the data_vars argument of the Dataset constructor. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The ISOMIP+ protocol prescribes a top drag coefficient of 2.5e-3, but implicit top drag used the MPAS-Ocean default of 1.0e-3. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
Author
TestingI ran Without the fix, Posted by Claude Code on @xylar's behalf. The testing, analysis and wording above are AI-authored; please check them accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ISOMIP+ tasks fail in
initial_statewith current xarray, which no longer accepts aDatasetin theDatasetconstructor. This PR fixes that and sets the implicit top drag coefficient to the ISOMIP+ value of 2.5e-3, which had been left at the MPAS-Ocean default of 1.0e-3. The drag change alters answers for all ISOMIP+ tasks.These tasks are the reference for the Polaris ISOMIP+ tasks in E3SM-Project/polaris#826.
Checklist
Testingin this PR) any testing that was used to verify the changes🤖 Generated with Claude Code