Skip to content

feat(macOS): add gamepad broker - #161

Draft
ReenigneArcher wants to merge 16 commits into
masterfrom
feat/macos-gamepad-support
Draft

ReenigneArcher wants to merge 16 commits into
masterfrom
feat/macos-gamepad-support

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Description

Adds macOS gamepad support.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher
ReenigneArcher marked this pull request as draft September 25, 2026 02:19
Comment thread src/platform/macos/broker/io.hpp Fixed
Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
Comment thread src/platform/macos/macos_broker_client.cpp Fixed
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.15509% with 519 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.66%. Comparing base (9b8e309) to head (da76c62).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...atform/macos/broker/libvirtualhid_macos_broker.cpp 0.00% 247 Missing ⚠️
src/platform/macos/macos_broker_client.cpp 9.59% 169 Missing and 10 partials ⚠️
src/platform/macos/broker/license_cli.cpp 0.00% 49 Missing ⚠️
src/platform/macos/broker/io.hpp 29.62% 34 Missing and 4 partials ⚠️
src/platform/macos/macos_backend.cpp 64.70% 0 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   73.97%   70.66%   -3.32%     
==========================================
  Files          40       45       +5     
  Lines       10107    10709     +602     
  Branches     3544     3749     +205     
==========================================
+ Hits         7477     7567      +90     
- Misses       1977     2456     +479     
- Partials      653      686      +33     
Flag Coverage Δ
FreeBSD 52.60% <80.00%> (+0.10%) ⬆️
Linux-Clang 55.45% <80.00%> (+0.06%) ⬆️
Linux-GCC 66.21% <95.00%> (+0.07%) ⬆️
PowerShell 75.60% <ø> (ø)
Windows-MSVC 88.57% <100.00%> (+0.04%) ⬆️
Windows-MinGW-UCRT64 63.79% <95.00%> (+0.08%) ⬆️
macOS 44.06% <14.54%> (-5.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/include/libvirtualhid/license.hpp 100.00% <ø> (ø)
src/platform/macos/broker/protocol.hpp 100.00% <100.00%> (ø)
src/platform/shared/lvh_broker_license_policy.hpp 100.00% <100.00%> (ø)
src/platform/macos/macos_backend.cpp 43.33% <64.70%> (+2.09%) ⬆️
src/platform/macos/broker/io.hpp 29.62% <29.62%> (ø)
src/platform/macos/broker/license_cli.cpp 0.00% <0.00%> (ø)
src/platform/macos/macos_broker_client.cpp 9.59% <9.59%> (ø)
...atform/macos/broker/libvirtualhid_macos_broker.cpp 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b8e309...da76c62. Read the comment docs.

Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
Comment thread src/platform/macos/broker/libvirtualhid_macos_broker.cpp Fixed
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sunshine: Gamepad support for macOS

2 participants