Repository navigation
fix(transport): preserve retry delay on service unavailable responses - #428
Merged
Merged
Conversation
This was referenced Nov 14, 2026
tkkhq
marked this pull request as ready for review
November 16, 2026 16:25
marckong
approved these changes
Nov 19, 2026
tkkhq
enabled auto-merge
November 20, 2026 04:03
tkkhq
disabled auto-merge
November 20, 2026 17:59
tkkhq
marked this pull request as draft
November 20, 2026 18:09
tkkhq
marked this pull request as ready for review
November 20, 2026 18:09
AI review: no P0-P2 findingsFor HTTP 503 responses, the SDK now reads a numeric Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.
Human review: not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking
Tracks: https://konghq.atlassian.net/browse/VOL-1428
Related: https://github.com/Kong/volcano-hosting/pull/3400
Related: docs(database): explain capacity refusal and safe retry guidance volcano-docs#189
Related: fix(transport): preserve retry delay on service unavailable responses volcano-sdk-ruby#378
Related: https://github.com/Kong/volcano-monitoring/pull/139
Why
Retry-After, but Python drops that retry delay when constructingServerError. Applications need the server's delay to bound their own retries.Summary
Retry-Afteron HTTP 503 as well as 429 without automatically replaying the requestKong/volcano-docs; publish that guidance after the Hosting and SDK behavior is releasedVerification
retry_afterwasNoneinstead of 17.uvx --from uv==0.12.17 uv run poe test— 3,007 passed.uvx --from uv==0.12.17 uv run poe lintuvx --from uv==0.12.17 uv run poe typesuvx --from uv==0.12.17 uv run poe format-checkuvx --from uv==0.12.17 uv run poe generateduvx --from uv==0.12.17 uv run poe package-check— isolated wheel/sdist installation and synthetic HTTP quickstart passed.