Repository navigation
fix(lavaflow): remove deployment status from covering PR output - #501
Conversation
AI review: no P0-P2 findingsRemoves the "Deployment" line that ⚪ P3
Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.
Human review: needed
The AI review found no P0-P2 problems at 15cf89a, so the code needs no second review for bugs. Decide the points above: approve to accept them, or request changes. Suggested reviewer: |
| @@ -510,9 +510,6 @@ func lavaflowFix(w io.Writer, on bool, run *apiclient.LavaflowRun) { | |||
| if cover := delivery.Coverage; cover != nil && pr == nil { | |||
There was a problem hiding this comment.
⚪ P3: The commit title says the change adds the covering PR state, but it actually removes the Deployment line
The base already printed Covering pull request and State for a covering PR (base internal/output/lavaflow.go:511-512). The only user-visible change here is that the Deployment: <time>|unconfirmed line no longer appears for a merged covering PR. release-please turns the squash title fix(lavaflow): show the covering pull request state into the CHANGELOG entry, so the release notes will describe something that already existed and won't mention the removed line. Consider a title like fix(lavaflow): stop printing deployment for a covering pull request so the changelog matches the behavior.
Found by claude-opus-5-5
marckong
left a comment
There was a problem hiding this comment.
Reviewed commit 15cf89a9ea3de16ef4f397793105c85d04de5909. No blocking findings.
The change removes the covering PR's deployment line while preserving its URL and GitHub state. JSON output remains unchanged.
Validation: go test ./internal/output ./internal/cmd/lavaflow and make openapi-generated-check passed locally. CI's check / check and check / localmode-e2e are also green.
One non-blocking compatibility caveat: older hosting responses with merge.reason = manual_deploy still render Merge: merged (manual deploy) through the existing formatter in internal/output/lavaflow.go:651-658. Unlike the companion web PR, this change does not suppress that legacy reason. Hosting #3547 removes it server-side. If the CLI should eliminate deployment wording independently of that rollout, suppress manual_deploy for merged runs here and add a legacy-response test.
Show the linked PR and its GitHub state when it covers a LavaFlow report. Remove the deployment line from the terminal fix summary, and synchronize the merge reason description in the generated client.
Companions: Hosting #3547 and Docs #247.
The LavaFlow CLI and output tests passed locally, including a merged covering PR carrying a deployment timestamp. Generated-client verification passed.