Skip to content

fix(lavaflow): remove deployment status from covering PR output - #501

Merged
swkeever merged 1 commit into
mainfrom
skeever/lavaflow-merge-report
Nov 20, 2026
Merged

swkeever merged 1 commit into
mainfrom
skeever/lavaflow-merge-report

Conversation

@swkeever

Copy link
Copy Markdown
Collaborator

Show the linked PR and its GitHub state when it covers a LavaFlow report. Remove the deployment line from the terminal fix summary, and synchronize the merge reason description in the generated client.

Companions: Hosting #3547 and Docs #247.

The LavaFlow CLI and output tests passed locally, including a merged covering PR carrying a deployment timestamp. Generated-client verification passed.

@swkeever
swkeever marked this pull request as ready for review November 20, 2026 02:05
@swkeever
swkeever requested a review from a team as a code owner November 20, 2026 02:05
Copilot AI balanced review requested due to automatic review settings November 20, 2026 02:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

Copy link
Copy Markdown

AI review: no P0-P2 findings

Reviewed 15cf89a. Run log

Removes the "Deployment" line that lavaflow printed under a merged covering pull request, adds an exact-output test for the covering pull request block, and drops manual_deploy from the vendored LavaflowMergeReason description and the generated client. Risk is low: the change only alters terminal text, the JSON output is unchanged, and the CLI never handled manual_deploy specially.

⚪ P3

  • internal/output/lavaflow.go:510 The commit title says the change adds the covering PR state, but it actually removes the Deployment line

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

Human review: needed

  • Is removing the Deployment field from volcano lavaflow show acceptable for users relying on that summary (internal/output/lavaflow.go)?

The AI review found no P0-P2 problems at 15cf89a, so the code needs no second review for bugs. Decide the points above: approve to accept them, or request changes.

Suggested reviewer: subnetmarco (most recent commits to the vendored openapi.yaml and generated client). Any collaborator with write access other than the author can approve.

@github-actions
github-actions Bot requested a review from subnetmarco November 20, 2026 02:07
@@ -510,9 +510,6 @@ func lavaflowFix(w io.Writer, on bool, run *apiclient.LavaflowRun) {
if cover := delivery.Coverage; cover != nil && pr == nil {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ P3: The commit title says the change adds the covering PR state, but it actually removes the Deployment line

The base already printed Covering pull request and State for a covering PR (base internal/output/lavaflow.go:511-512). The only user-visible change here is that the Deployment: <time>|unconfirmed line no longer appears for a merged covering PR. release-please turns the squash title fix(lavaflow): show the covering pull request state into the CHANGELOG entry, so the release notes will describe something that already existed and won't mention the removed line. Consider a title like fix(lavaflow): stop printing deployment for a covering pull request so the changelog matches the behavior.

Found by claude-opus-5-5

@swkeever swkeever changed the title fix(lavaflow): show the covering pull request state fix(lavaflow): remove deployment status from covering PR output Nov 20, 2026
@swkeever
swkeever enabled auto-merge November 20, 2026 14:36

@marckong marckong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit 15cf89a9ea3de16ef4f397793105c85d04de5909. No blocking findings.

The change removes the covering PR's deployment line while preserving its URL and GitHub state. JSON output remains unchanged.

Validation: go test ./internal/output ./internal/cmd/lavaflow and make openapi-generated-check passed locally. CI's check / check and check / localmode-e2e are also green.

One non-blocking compatibility caveat: older hosting responses with merge.reason = manual_deploy still render Merge: merged (manual deploy) through the existing formatter in internal/output/lavaflow.go:651-658. Unlike the companion web PR, this change does not suppress that legacy reason. Hosting #3547 removes it server-side. If the CLI should eliminate deployment wording independently of that rollout, suppress manual_deploy for merged runs here and add a legacy-response test.

@swkeever
swkeever added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit bd87ac3 Nov 20, 2026
29 of 30 checks passed
@swkeever
swkeever deleted the skeever/lavaflow-merge-report branch November 20, 2026 15:09
@kong-volcano-app kong-volcano-app Bot mentioned this pull request Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants