Repository navigation
CLI: dump flags replace its defaults, so dump -nc works (#99) - #123
Merged
Merged
Conversation
`dump` is `cat --no-borders --no-header --comments --horizontal` plus the user's arguments, so `dump -nc` gave cat both --comments and --no-comments and argparse refused. dump now adds a default only when the user named neither flag of its pair; the arguments are passed on quoted. Help text says so. Closes #99 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ccdb dumpiscat --no-borders --no-header --comments --horizontalplus the user's arguments, sodump -ncgave cat two contradicting flags. dump now adds each default only when the user named neither flag of its pair (borders, header, comments, orientation); arguments are passed on quoted.Tests:
test_dump_flags_override_defaults,test_dump_cat_flagsin integ_test_cli_manager (45 tests pass).Closes #99
🤖 Generated with Claude Code