fix: align CREATE and ALTER index option boundaries - #2702
Merged
manticore-projects merged 1 commit intoSep 25, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALTER TABLE ADD key options took a different path from CREATE TABLE: PostgreSQL
USING INDEX TABLESPACEwas consumed as an index access method, and MySQLSECONDARY_ENGINE_ATTRIBUTEwas not recognized.Keep the PostgreSQL constraint-options boundary intact and share MySQL scalar engine-attribute parsing with table options. This also gives table ENGINE_ATTRIBUTE/SECONDARY_ENGINE_ATTRIBUTE clauses the existing mutable TableOption representation, while retaining the legacy index-option token API.
Validation: full Gradle check and grammar ambiguity gate; tablespace mutation, MySQL option boundaries and table-attribute mutation tests. All five audited PostgreSQL TABLESPACE cases and both MySQL index-attribute variants pass execution/catalog comparison on PostgreSQL 18.6 and MySQL 9.7.2/26.7.0 respectively.