feat: extend PostgreSQL sequence creation and alteration - #2701
Merged
manticore-projects merged 1 commit intoSep 25, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL sequence DDL was missing persistence and existence modifiers and most non-parameter ALTER actions. OWNED BY was also restricted to the end, rejecting valid option ordering.
Share AS/OWNED BY/numeric option parsing between CREATE and ALTER while retaining the existing Sequence and SequenceOwnership APIs. Add structured creation persistence, IF [NOT] EXISTS, and ALTER rename, owner, schema and logging actions. Route both deparsers through each statement's common printer so these flags and subsequent AST edits are preserved.
Validation: full Gradle check and grammar ambiguity gate; mutation, option ordering, scoped temporary forms and following-statement tests. All 33 previously failing sequence cases, including standalone PostgreSQL regression-test inputs, execute successfully and retain their catalog results on PostgreSQL 18.6.