fix: model PostgreSQL DROP INDEX CONCURRENTLY - #2699
Merged
manticore-projects merged 1 commit intoSep 25, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DROP INDEX CONCURRENTLY ixpreviously storedCONCURRENTLYas the object name andixas a trailing token. Renaming the target through the AST generated invalid SQL, and addingIF EXISTSfailed to parse.Model concurrency independently of the index name and render it before
IF EXISTSthrough the shared Drop printer. Tests cover qualified names, target replacement, removing concurrency, quoted identifiers, MySQL index options, reparsing and following statements.Validation: full Gradle check including the grammar ambiguity gate; PostgreSQL 18.6 execution and catalog comparison for the audited IF EXISTS case and target-renaming mutation.