fix: keep PostgreSQL column constraint names and attributes together - #2698
Merged
manticore-projects merged 1 commit intoSep 25, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL column PRIMARY KEY and UNIQUE names and attributes were split between raw column tokens and the constraint node. Renaming a constraint or replacing its deferrability could therefore generate duplicate, invalid SQL. Named column REFERENCES clauses had the same ownership problem.
Keep names and attributes on their structured nodes through the shared CREATE TABLE / ALTER TABLE ADD COLUMN path, reusing the existing constraint-attribute parser. Also allow table CHECK attributes to surround NO INHERIT, while retaining the column CHECK ordering boundary.
Validation: full Gradle check, grammar ambiguity gate, AST rename/removal and attribute replacement tests, both printers and reparsing. PostgreSQL 18.6 accepted all 10 audited CHECK-order variants and the corrected column-constraint mutations; MySQL 9.7.2 and 26.7.0 CHECK mutation controls remain valid. DB comparisons include constraint names and catalog flags.