feat: model PostgreSQL temporal key and foreign key constraints - #2697
Merged
manticore-projects merged 2 commits intoSep 24, 2026
Merged
manticore-projects merged 2 commits into
manticore-projects merged 2 commits into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Please resolve conflicts |
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 18 adds temporal PRIMARY KEY/UNIQUE constraints with
WITHOUT OVERLAPSand foreign keys withPERIOD. These forms currently fail to parse, preventing schema tools from reading temporal table definitions.Add explicit temporal markers to index-column metadata and the foreign-key reference model. PRIMARY KEY and UNIQUE share the existing index-key parser; both sides of a foreign key share a column-list parser that enforces the final-column position of PERIOD. CREATE TABLE and ALTER TABLE ADD reuse these paths. The legacy referenced-column-name list keeps bare names and remains mutable.
Execution comparison also exposed a related ALTER UNIQUE bug: named PostgreSQL constraints lost their names on output. Reusing
NamedConstraintpreserves the name for both ordinary and temporal UNIQUE constraints.Validation:
checkwith Java 17, including grammar ambiguity and static analysis.periodidentifiers, statement boundaries, and malformed marker placement.toString(), and deparser SQL, including constraint names and temporal catalog flags. Behavior checks verify overlap rejection and a child range covered jointly by adjacent parent ranges.Use
Dialect.POSTGRESQLfor the PostgreSQL ALTER constraint paths. Reference: PostgreSQL 18 CREATE TABLE.