fix: share PostgreSQL typed and partition table column overrides - #2693
Merged
manticore-projects merged 3 commits intoSep 25, 2026
Merged
manticore-projects merged 3 commits into
manticore-projects merged 3 commits into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Please resolve conflicts. |
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
sorry, conflict again. |
Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CREATE TABLE OF type-name parsing so the first column override is not mistaken for a type argument. Parse PARTITION OF overrides without requiring a new data type.
Both forms reuse the existing typed column-definition path and common ColumnDefinitionOption AST/rendering, also used by ALTER column definitions. Preserve the public ColDataType API for OF, and distinguish bare overrides from CTAS output-column lists.
Validation:
checkpassed (Java 17), including grammar ambiguity, unit tests, coverage, formatting, Checkstyle, PMD, and SpotBugs.Syntax reference: official documentation.
Additional version-boundary validation: the original, toString, and deparser SQL was executed on PostgreSQL 18.6, including the focused behavioral cases. Reviewed the PostgreSQL 18 grammar. Runtime version numbers above identify the tested binaries; this does not claim support for every statement in those DBMS versions.