Repository navigation
#232 dynamic benchmark bar - #233
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The visibility condition keeps progress visible in cases where the PR description requires hiding it.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds dynamic visibility for JDiskMark’s benchmark progress panel.
Changes:
- Refreshes visibility on tab changes, initialization, and sensitivity updates.
- Documents the visibility rule and reuse of hidden panel space.
| File | Description |
|---|---|
| jdm-core/src/main/java/jdiskmark/MainFrame.java | Adds progress-panel visibility logic and update hooks. |
| jdm-core/docs/design.md | Documents progress-panel visibility behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hide the benchmark progress when not on the benchmark tab or when there is not one in progress
prevents display of a progress bar when it is not needed or relevant.