Skip to content

fix(moore): use portable fp16 type mapping - #56

Merged
baominghelly merged 1 commit into
masterfrom
fix/moore-half-type
Nov 16, 2026
Merged

baominghelly merged 1 commit into
masterfrom
fix/moore-half-type

Conversation

@baominghelly

Copy link
Copy Markdown
Contributor

Summary

  • map Moore FP16 to the host-portable Float16 type in its public type mapping.

Context

9e2e985f started exporting each enabled backend's data_type_.h through generated.h. On Moore, this exposed the mapping to MUSA half, but musa_fp16.h does not define half (or __half) for the host compilation used by InfiniRT's mcc_wrapper.sh path. This made public headers and reusable_memory_pool.cc fail with unknown type name 'half'.

The public mapping is a host-side dispatch/tag type. The common Float16 type is portable, has the required 2-byte representation, and avoids depending on MUSA compiler-internal type definitions.

Validation

Built on a Moore runner with MUSA 4.3.1:
cmake -S . -B build -DWITH_CPU=ON -DWITH_MOORE=ON -DCMAKE_BUILD_TYPE=Release && cmake --build build -j8

Before this change, the build fails in reusable_memory_pool.cc / generated public headers. With this change, infinirt builds and links. Also installed headers and compiled a downstream public-header consumer against the installed library successfully.

@baominghelly
baominghelly merged commit c0810cf into master Nov 16, 2026
6 checks passed
@baominghelly
baominghelly deleted the fix/moore-half-type branch November 16, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants