Fix CI: bump ruff/zuban, remove dead code, drop leaked codecov token - #247
Merged
Merged
Conversation
Ruff 0.16 promoted CPY001 (copyright notice) to stable under our select=ALL config, breaking CI on every file; ignore it. Bumped pre-commit hook revs to match. Removed a bytes-decode branch in processing.py that static analysis confirms is unreachable given niquests' typed headers.get() return. Dropped the plaintext codecov upload token from codecov.yml (public repo, tokenless upload works).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select=ALLconfig, breaking CI on every file; addedCPYto ignoreprocessing.py— static analysis confirms it's unreachable given niquests' typedheaders.get()returncodecov.yml(public repo, tokenless upload works; CI itself usessecrets.CODECOV_TOKEN, untouched)labelsfield addition in Addlabelsfield to EntityRegistryEntry #246Test plan
ruff format --check,ruff check,zuban checkall pass