Repository navigation
feat(dialtesting): add DNS probes and encrypted transports - #212
Merged
Merged
Conversation
|
zhangwenjie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
leecha
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNS tasks can now query a configured resolver over UDP/TCP, DoT, DoH (HTTP/1.1, HTTP/2 or HTTP/3), or DoQ using the existing task lifecycle and reporting contract. Resolver hostnames, IPv4/IPv6, pinned addresses, certificate validation and mTLS share one cancellable timeout; automatic TCP fallback happens only for truncated UDP responses.
Adds A/AAAA/CNAME/MX/NS/TXT conditions with flat AND/OR semantics, DNSSEC request flags and AD assertions, bounded query/assertion JSON details, and credential redaction. Protocol failures cannot pass through OR or timing conditions. Rejects JSON-null task payloads without panicking. Includes the existing x/net version's DNS codec in vendor without changing dependency versions. Usage and result semantics are documented in
dialtesting/DNS.md.Validation:
make testpasses on Go 1.27 and on the CI Go 1.25 toolchain withWITHIN_GITHUB_WORKFLOW=true.make lint LINT_FIX=falsepasses with golangci-lint v2.4.0;go build ./...passes.go build ./dialtestingpasses. Local DataKit and Kodo integration regressions also pass against this implementation.Repository-wide copyright checking still reports pre-existing header issues outside this change; all new Go files have the required headers.
Compatibility follow-up (29d53db):
ITask/TaskChildinterfaces, shared task fields, legacy protocol implementations, dependency versions and existing result contracts remain unchanged.TestTraceroute. That test exposes an unchanged race between the two writers intraceroute_other.go; the same race was reproduced against the PR base. This PR does not change that implementation.