Repository navigation
fix(dialtesting): require responses for TCP message assertions - #211
Merged
Merged
Conversation
|
zhangwenjie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
leecha
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For TCP tasks with nonempty connection assertions, response-message assertions now require an actual response. Refused or timed-out connections cannot satisfy negative message checks using the default empty string. A matching connection assertion can still satisfy OR, and response availability resets between runs. Tasks without connection assertions retain their existing message semantics.
Empty, null, and omitted connection fields keep the existing behavior: they do not enable the new connection mode. They remain equivalent when omitempty serialization removes an empty array. Compatibility tests verify that connection failures still fail in this mode; an empty array does not make failed connections succeed. Existing validation of nonempty elements, operators, and targets is unchanged.
Follow-up to #210 and the review on DataKit !4227. The empty-array review concern is addressed through an explicit compatibility contract and regression tests rather than rejecting a previously accepted optional field. Final production diff adds seven lines and no public fields or execution features.
Validation:
DataKit and kodo synchronization is paused at the user's request.