Repository navigation
Phase 5: DEVELOPER Status fields; Liaison's map in place of pMarineViewer; stop at allstop - #24
Merged
Merged
Conversation
Each behavior's priority weight, pieces, create CPU and update summary come from HelmReport's full behavior lists. Status also gains the warning and completed counts, the helm's CPU load, and each iteration's update results (IVPHELM_UPDATE_RESULT). A scenario test covers these and the objective functions, and the README gets an outline for a helm library section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
goby_liaison now runs with the alpha launch: its Map tab shows the vehicle and its track, Scope the helm's messages, and Commander publishes a Variable or Command to the helm in place of pMarineViewer's buttons. set_datum_warp.sh opens the map at the datum. viewer.launch, alpha.moos and get_images.sh go, and init.sh installs goby3-gui instead of MOOSDB, MOOS-IvP's apps and goby3-moos. The goby_moos_gateway plugin still builds, for MOOS communities. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
When alpha's return completed (DEPLOY=false), the helm went to NothingToDo and output no solution again: pHelmIvP posts an allstop's zero DESIRED_* only when it changes, and after a no-decision allstop's iteration of grace not at all, relying on pMarinePID to stop on stale input. A Goby frontseat holds its last DesiredCourse, so the vehicle ran on at 2 m/s. The helm now outputs the allstop's zero solution on every iteration of it, after the grace. replay still compares only what pHelmIvP posts. The s1_alpha closed loop now runs to the end of the mission: the vehicle must stop within 10 m of the return point and stay there. test_helm's mission_end checks the zero solutions directly. deploy.sh loads IvPico's own build/usr/lib/libivpico_interface.so, so GOBY_TOOL_LOAD_SHARED_LIBRARY needn't be set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
A GOBY_TOOL_LOAD_SHARED_LIBRARY already set for another project took the place of IvPico's library, and the publish failed with "Unknown type ivp.interface.Variable". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 (DEVELOPER) of the Goby helm plan, stacked on #23. Objective functions (
BHV_IPF) were already output, and rejournal stays a no-op since every Status is complete. This PR fills the rest of the DEVELOPER Status, replaces pMarineViewer in the alpha launch with Liaison's map, and fixes the vehicle running away at the end of the alpha mission.Changes
update_summaryfor every behavior.priority_weight,piecesandcreate_cpuwhile it's active, as pHelmIvP reports them.warning_count: the WARNING behavior events so far.completed_count.cpu_load: the helm's percentage of one CPU between iterations.update_result: each iteration's behavior updates and their results (success, duplicate, name mismatch or parameter error), the equivalent ofIVPHELM_UPDATE_RESULT.alpha.launchrunsgoby_liaisonat http://localhost:50001:VariableorCommandto the helm, in place of pMarineViewer's buttons.set_datum_warp.shopens the map at the datum.deploy.shloads IvPico's ownbuild/usr/lib/libivpico_interface.so, soGOBY_TOOL_LOAD_SHARED_LIBRARYneedn't be set.viewer.launch,alpha.moosandget_images.share removed.init.shinstallsgoby3-guiinstead of MOOSDB, MOOS-IvP's apps andgoby3-moos.goby_moos_gatewayplugin still builds, for MOOS communities.Visualizations (waypoints, ...) yet.DEPLOY=false) the vehicle ran on at 2 m/s:DESIRED_*only when the allstop changes. For a no-decision allstop (NothingToDo, ...), it posts none at all after the iteration of grace.DESIRED_*go stale. A Goby frontseat instead holds the lastDesiredCourse.replaystill compares only what pHelmIvP posts.init.sh(everything from apt.oceansoft.org).Standby helm stays deferred.
Testing
developer_statusscenario test:mission_endscenario: once the behaviors complete, every iteration ofNothingToDoafter the grace has a zero solution, and the vehicle stops;allstopscenario now expects zero solutions throughMissingDecVars;closed_loop_s1_alphatest runs to the end of the mission: the vehicle must stop within 10 m of the return point and stay there;init.sh, the build and all 37 tests in cleanubuntu:24.04andubuntu:26.04containers, and all 37 locally with the fix.deploy.shand noGOBY_TOOL_LOAD_SHARED_LIBRARY, in a cleanubuntu:24.04container:ivp.interface.Variableandivp.interface.Command.🤖 Generated with Claude Code
https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp