Skip to content

Phase 5: DEVELOPER Status fields; Liaison's map in place of pMarineViewer; stop at allstop - #24

Merged
tsaubergine merged 6 commits into
advanced-featuresfrom
developer-features
Nov 13, 2026
Merged

tsaubergine merged 6 commits into
advanced-featuresfrom
developer-features

Conversation

@tsaubergine

@tsaubergine tsaubergine commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Phase 5 (DEVELOPER) of the Goby helm plan, stacked on #23. Objective functions (BHV_IPF) were already output, and rejournal stays a no-op since every Status is complete. This PR fills the rest of the DEVELOPER Status, replaces pMarineViewer in the alpha launch with Liaison's map, and fixes the vehicle running away at the end of the alpha mission.

Changes

  • Per behavior:
    • update_summary for every behavior.
    • priority_weight, pieces and create_cpu while it's active, as pHelmIvP reports them.
    • All four come from HelmReport's full behavior lists.
  • Status:
    • warning_count: the WARNING behavior events so far.
    • completed_count.
    • cpu_load: the helm's percentage of one CPU between iterations.
  • update_result: each iteration's behavior updates and their results (success, duplicate, name mismatch or parameter error), the equivalent of IVPHELM_UPDATE_RESULT.
  • README: an outline of a "Helm library" section to be filled in, covering the API, each iteration's output, the field levels and where the helm differs from pHelmIvP.
  • Alpha launch, Liaison in place of pMarineViewer:
    • alpha.launch runs goby_liaison at http://localhost:50001:
      • Map shows the vehicle and its track;
      • Scope shows the helm's messages;
      • Commander publishes a Variable or Command to the helm, in place of pMarineViewer's buttons.
    • set_datum_warp.sh opens the map at the datum.
    • deploy.sh loads IvPico's own build/usr/lib/libivpico_interface.so, so GOBY_TOOL_LOAD_SHARED_LIBRARY needn't be set.
    • viewer.launch, alpha.moos and get_images.sh are removed.
    • init.sh installs goby3-gui instead of MOOSDB, MOOS-IvP's apps and goby3-moos.
    • The goby_moos_gateway plugin still builds, for MOOS communities.
    • Liaison's map doesn't draw the helm's Visualizations (waypoints, ...) yet.
  • Stop at allstop. At the end of alpha's return (DEPLOY=false) the vehicle ran on at 2 m/s:
    • pHelmIvP posts an allstop's zero DESIRED_* only when the allstop changes. For a no-decision allstop (NothingToDo, ...), it posts none at all after the iteration of grace.
    • MOOS-IvP relies on pMarinePID stopping when DESIRED_* go stale. A Goby frontseat instead holds the last DesiredCourse.
    • The helm now outputs the allstop's zero solution on every iteration of it, after the grace.
    • replay still compares only what pHelmIvP posts.
  • Merges Phase 4: typed visualizations and offboard messages, configuration, restart, ok_skew #23's init.sh (everything from apt.oceansoft.org).

Standby helm stays deferred.

Testing

  • New developer_status scenario test:
    • a timer sends a constant-heading behavior one good update and one bad one, then completes;
    • checks both update results, the completed count, the active behavior's priority weight, pieces, create CPU and update summary, and its objective functions.
  • Stop at allstop:
    • new mission_end scenario: once the behaviors complete, every iteration of NothingToDo after the grace has a zero solution, and the vehicle stops;
    • the allstop scenario now expects zero solutions through MissingDecVars;
    • the closed_loop_s1_alpha test runs to the end of the mission: the vehicle must stop within 10 m of the return point and stay there;
    • all three fail without the fix.
  • init.sh, the build and all 37 tests in clean ubuntu:24.04 and ubuntu:26.04 containers, and all 37 locally with the fix.
  • The alpha launch, deployed with deploy.sh and no GOBY_TOOL_LOAD_SHARED_LIBRARY, in a clean ubuntu:24.04 container:
    • Liaison's Map tab shows the survey, the return, and alpha stopped at (-7, -18);
    • Commander offers ivp.interface.Variable and ivp.interface.Command.
  • CI.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp

Each behavior's priority weight, pieces, create CPU and update summary
come from HelmReport's full behavior lists. Status also gains the
warning and completed counts, the helm's CPU load, and each
iteration's update results (IVPHELM_UPDATE_RESULT). A scenario test
covers these and the objective functions, and the README gets an
outline for a helm library section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
goby_liaison now runs with the alpha launch: its Map tab shows the
vehicle and its track, Scope the helm's messages, and Commander
publishes a Variable or Command to the helm in place of pMarineViewer's
buttons. set_datum_warp.sh opens the map at the datum.

viewer.launch, alpha.moos and get_images.sh go, and init.sh installs
goby3-gui instead of MOOSDB, MOOS-IvP's apps and goby3-moos. The
goby_moos_gateway plugin still builds, for MOOS communities.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
@tsaubergine tsaubergine changed the title Phase 5: DEVELOPER Status fields and update results Phase 5: DEVELOPER Status fields and update results; Liaison's map in place of pMarineViewer Nov 13, 2026
When alpha's return completed (DEPLOY=false), the helm went to
NothingToDo and output no solution again: pHelmIvP posts an allstop's
zero DESIRED_* only when it changes, and after a no-decision allstop's
iteration of grace not at all, relying on pMarinePID to stop on stale
input. A Goby frontseat holds its last DesiredCourse, so the vehicle ran
on at 2 m/s.

The helm now outputs the allstop's zero solution on every iteration of
it, after the grace. replay still compares only what pHelmIvP posts.

The s1_alpha closed loop now runs to the end of the mission: the vehicle
must stop within 10 m of the return point and stay there. test_helm's
mission_end checks the zero solutions directly.

deploy.sh loads IvPico's own build/usr/lib/libivpico_interface.so, so
GOBY_TOOL_LOAD_SHARED_LIBRARY needn't be set.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
@tsaubergine tsaubergine changed the title Phase 5: DEVELOPER Status fields and update results; Liaison's map in place of pMarineViewer Phase 5: DEVELOPER Status fields; Liaison's map in place of pMarineViewer; stop at allstop Nov 13, 2026
A GOBY_TOOL_LOAD_SHARED_LIBRARY already set for another project took
the place of IvPico's library, and the publish failed with "Unknown type
ivp.interface.Variable".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
@tsaubergine
tsaubergine added this pull request to stack #25 November 13, 2026 06:56
@tsaubergine
tsaubergine merged commit 7a00b93 into main Nov 13, 2026
4 checks passed
@tsaubergine
tsaubergine deleted the developer-features branch November 13, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants