Repository navigation
Phase 3: contacts, with the helm raising contact alerts itself - #22
Merged
Merged
Conversation
COPYING carries the license texts, and every source file gets a header. src/lib/helm/helm.cpp ports pHelmIvP's logic, so it is GPL 3+ like MOOS-IvP, and so are the mission fixtures and alpha.bhv copied from MOOS-IvP's missions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
ContactManager ports pContactMgrV20's alert handling: BCM_ALERT_REQUESTs from behaviors and configured alerts, range and CPA checks, alert filters, early and cease warnings, retirement, and the disable/enable/expunge variables that become BHV_ABLE_FILTER. CMAlert and PlatformAlertRecord are copied unchanged from pContactMgrV20. Its posts come out as CONTACT_MANAGER postings and reach the behaviors on the next iteration, as they would through the MOOSDB. contact_alerts: false leaves alerts to an outside contact manager. Range reports and display radii are left out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
HelmReport keeps a completed behavior's name in its completed list, so a behavior respawned under that name showed as COMPLETED in Status. The completed list now goes first, and the live states override it. Also leaves an alert that a behavior's request will complete out of the contact manager's configuration warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
record.sh runs multi-vehicle missions from their own launch.sh --just_make, with a fixture per vehicle (fixtures/<mission>.<vehicle>), and trims pHelmIvP's app logging and objective functions from the fixtures. missions.txt adds s1_alpha_obsavoid and five contact missions, recorded at warp 4. replay --alerts (ctest replay_<fixture>_alerts) drops pContactMgrV20's recorded posts and has the helm raise contact alerts itself from the .moos file's pContactMgrV20 block, comparing its posts with pContactMgrV20's. ivpico_ghost replays other vehicles' recorded NODE_REPORTs to goby_helm_ivp for the m2_berta closed-loop test, and publishes their range to ownship. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
MOOS-IvP's pHelmIvP now gives NothingToDo, NoGoalBehavior and missing decisions one iteration's grace without relabelling the allstop, and park_on_allstop parks only on BehaviorError or DisabledByStandbyHelm. On other allstops the helm keeps control and decides again once they clear, so a survey that ends no longer parks the vehicle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
pHelmIvP's IVPHELM_LEDGER_SUMMARY gives how many contact reports its ledger had taken in by each iteration, so relayed NODE_REPORTs go to the helm on the iteration pHelmIvP got them instead of by their log times. A change with the same text on the same iteration but different numbers counts against its own, looser allowance, and a change within tolerance of the value before it is skipped. --alerts compares only the helm state, allstops, modes, life events, active behaviors and the contact manager's posts, since a behavior spawned an iteration later posts every value an iteration later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
ivpico_ghost reads GOBY_INTERPROCESS and copes with empty alog values; its paths are relative to its own test directory. The test also checks that ben comes within 100 m, so keeping clear of him means something. ufld_convoy's pHelmIvP looks for behaviors in a directory on its author's machine, and is MALCONFIG anywhere else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
Recorded from GobySoft/moos-ivp's ivp-without-moos, with IvPContactBehavior's bearing line label initialised (until that's in the branch, the label's color is whatever was in memory). The single-vehicle missions are re-recorded under the current pHelmIvP's allstop handling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
1 task done
A change that differs from the other helm's only in its numbers, on the same iteration, was skipped as insignificant when it was close to the value before it, leaving its counterpart missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp
Member
Author
|
CI fails The cause is in MOOS-IvP, not this PR.
The fix is 9d7aa7b, on GobySoft/moos-ivp's Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of the Goby helm plan. The helm handles contacts and raises pContactMgrV20's alerts itself, so contact behaviors spawn without a separate contact manager. Multi-vehicle MOOS-IvP missions replay against pHelmIvP, and m2_berta runs closed loop under Goby with a ghost contact.
Changes
src/lib/helm/contact_manager.{h,cpp}, a port of pContactMgrV20).disable_var/enable_var/expunge_varbecomeBHV_ABLE_FILTER.CONTACT_MANAGERpostings and reach behaviors on the next iteration, as through the MOOSDB.helm.contact_manager;contact_alerts: falseleaves alerts to an outside contact manager.CMAlertandPlatformAlertRecordare copied unchanged intosrc/lib/helm/contacts, rather than moved into MOOS-IvP's libraries, to keepivp-without-moosminimal.NothingToDo,NoGoalBehaviorand missing decisions get one iteration's grace.park_on_allstopparks only onBehaviorErrororDisabledByStandbyHelm.record.shrecords multi-vehicle missions.launch.sh --just_make, with a fixture per vehicle (fixtures/<mission>.<vehicle>).replaychanges:IVPHELM_LEDGER_SUMMARY's report count), not by log time.replay --alerts(ctestreplay_<fixture>_alerts) drops pContactMgrV20's recorded posts and has the helm raise alerts itself. It compares state, allstops, modes, life events, active behaviors and the contact manager's posts.ivpico_ghost(test only, not installed) replays other vehicles' recorded NODE_REPORTs togoby_helm_ivpand publishes their range to ownship.closed_loop_m2_bertachecks that abe spawnsavdcol_benfrom its own alert.Testing
closed_loop_m2_bertaincluded.libivp-helm24.8.1+git5536.g76684e8, all 25 replays pass. That package includes the fix forIvPContactBehavior::m_bearing_line_label_show, which the first CI run tripped over. The contact replays also pass with the heap forced to zero (MALLOC_PERTURB_=255).🤖 Generated with Claude Code
https://claude.ai/code/session_01VLcYK4e29B5FiPbDDJy5fp