Repository navigation
feat(tailscale): isolate tag:dntls to peers, Studio, and MacBook - #26
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tag:dntlshosts may reach each other, Studio, and the MacBook on any port, and nothing else in the tailnet.tag:dntls→tag:dntls:*,studio-1:*,studio-1-v6:*,macbook-pro:*,macbook-pro-v6:*.macbook-prois new), so the rule admits either address. MagicDNS names resolve to IPv4 only today (no AAAA answer fromsandbox01), so connections by name use the IPv4 aliases.tag:dntlsas a source: tagged devices are notautogroup:member/autogroup:admin, and the routed-range rules match subnet IPs, not tailnet IPs.autogroup:admin→*:*.Tests
New
tag:dntlspolicy test: accepts peer, Studio, and MacBook ports over both families; denies an address adjacent to the MacBook,tag:agentcompute,tag:sandbox,tag:subnet-router, the lab Incus API, and lab/home routed hosts.Validation
Sync tailnet policy(gitops-acl-actiontest) validates the policy and runs its tests against the tailnet.masterapplies it.