Repository navigation
ci: align workflow pins and permissions with the other repositories - #42
Merged
Merged
Conversation
…python v7.1.0 final-check.yml and the other GetTechAPI repositories already run these releases; the two older workflows were still on checkout v4.4.0 and setup-python v5.6.0. The Pages actions were already current.
validate-data ran with the default token permissions, never cancelled a superseded run and had no timeout. Give it contents: read, a per-ref concurrency group and a 10 minute limit. The Pages build and deploy jobs get timeouts as well. What the jobs run is unchanged.
The README named the field source_url; the validator and the PR template use source_urls. It also left out app/ingest/from_table.py, its entry point and what it writes, and listed only part of the tree. The classifier docstring said unknown candidates go to a review issue, which nothing in the code does: they are reported and skipped.
TechEngineBot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
validate-dataanddeploy-pagespinned older action releases thanfinal-checkand the other GetTechAPI repositories, andvalidate-dataran without apermissions:block, concurrency or a timeout. This brings the three workflows to the same pins and givesvalidate-dataread-only permissions. The README now matches the code.Changes
validate-data.ymlanddeploy-pages.yml. The Pages actions were already current.validate-data.yml:permissions: contents: read, per-ref concurrency, a 10-minute timeout.deploy-pages.ymlgets job timeouts. What the jobs do is unchanged.source_url→source_urls; a full Layout section; how to run the table ingest (python -m app.ingest.from_table TABLE [--dry-run]); how this repository relates to TechAPI.app/ingest/classify.pyno longer says unknown rows go to a review issue; nothing files one..editorconfigand.gitattributes; every tracked file was already LF.No file under
data/changes.Checks
pytest: 22 passed locally.