Repository navigation
Add auto-healing SCM options with progressive cooling off - #696
Merged
Merged
Conversation
planetchili
requested review from
markgalvan-intel
and
a balanced review from Copilot
October 5, 2026 20:17
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The recovery configuration, argument handling, diagnostics, and documentation are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Windows SCM crash recovery with progressive restart delays and recovery diagnostics.
Changes:
- Configures four delayed recovery attempts before remaining stopped.
- Passes and logs the SCM failure count.
- Corrects reset-event creation validation and documents recovery behavior.
| File | Description |
|---|---|
README-Service.md |
Documents recovery timing and client behavior. |
ServiceMain.cpp |
Logs recovery failure counts. |
Service.cpp |
Corrects event-handle validation. |
CliOptions.h |
Adds the recovery-count option. |
Library.wxs |
Configures SCM recovery actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
markgalvan-intel
approved these changes
Oct 5, 2026
markgalvan-intel
left a comment
markgalvan-intel
left a comment
Collaborator
There was a problem hiding this comment.
Nice robustness improvement! Great stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.