Repository navigation
Conversation
…erture using JRC; Adding unit test
LilianeRA
requested review from
OmarDuran,
cssherman,
dkachuma,
jafranc,
jhuang2601,
joshua-white and
rrsettgast
as code owners
October 9, 2026 21:39
LilianeRA
marked this pull request as draft
October 9, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes modifying the parallel-plates constitutive class to account for fracture roughness when computing its permeability.
To achieve this, we compute a mechanical-to-hydraulic aperture correction using the JRC (Barton et al, 1985).
The adopted definitions are as follows:
Sample files provided in "inpuFiles/jointRoughnessCoefficient/"
Unit test is located at "src/coreComponents/constitutive/unitTest/testJointRoughnessCoefficient.cpp"
If the JRC is not defined in the input file, the computation follows the original parallel-plates law.
Reference:
Barton, N., Bandis, S., & Bakhtar, K. (1985). Strength, deformation and conductivity coupling of rock joints. International Journal of Rock Mechanics and Mining Sciences & Geomechanics Abstracts, 22(3), 121–140.
https://doi.org/10.1016/0148-9062(85)93227-9