Fix gcc 12 compilation

[dkachuma]

On gcc 12 on one of our machines, I'm getting the error below. This is the proposed fix

coreComponents/physicsSolvers/multiphysics/CMakeFiles/multiPhysicsSolvers.dir/__/__/__/generatedSrc/coreComponents/physicsSolvers/multiphysics/poromechanicsKernels/PoromechanicsKernels_CellElementSubRegion_PorousSolid_DruckerPragerExtended__ConstantPermeability__H1_Hexahedron_Lagrange1_GaussLegendre2.cpp.o] Error 1
In file included from /src/geos/src/coreComponents/physicsSolvers/multiphysics/poromechanicsKernels/MultiphasePoromechanics_impl.hpp:28,
                 from /build/geos/release/generatedSrc/coreComponents/physicsSolvers/multiphysics/poromechanicsKernels/PoromechanicsKernels_CellElementSubRegion_PorousSolid_DruckerPragerExtended__ConstantPermeability__H1_Wedge_Lagrange1_Gauss6.cpp:17:
In function ‘void geos::compositionalMultiphaseUtilities::shiftBlockRowsAheadByOneAndReplaceFirstRowWithColumnSum(geos::integer, geos::integer, geos::integer, geos::integer, MATRIX&&, VEC&&) [with MATRIX = double (&)[3][18]; VEC = double (&)[18]]’,
    inlined from ‘void geos::compositionalMultiphaseUtilities::shiftRowsAheadByOneAndReplaceFirstRowWithColumnSum(geos::integer, geos::integer, MATRIX&&, VEC&&) [with MATRIX = double (&)[3][18]; VEC = double (&)[18]]’ at /src/geos/src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseUtilities.hpp:219:58,
    inlined from ‘geos::real64 geos::poromechanicsKernels::MultiphasePoromechanics<SUBREGION_TYPE, CONSTITUTIVE_TYPE, FE_TYPE>::complete(geos::localIndex, StackVariables&) const [with SUBREGION_TYPE = geos::CellElementSubRegion; CONSTITUTIVE_TYPE = geos::constitutive::PorousSolid<geos::constitutive::DruckerPragerExtended, geos::constitutive::ConstantPermeability>; FE_TYPE = geos::finiteElement::H1_Wedge_Lagrange1_Gauss6_impl]’ at /src/geos/src/coreComponents/physicsSolvers/multiphysics/poromechanicsKernels/MultiphasePoromechanics_impl.hpp:668:55:
/src/geos/src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseUtilities.hpp:189:26: error: iteration 2147483646 invokes undefined behavior [-Werror=aggressive-loop-optimizations]
  189 |         mat[i][j] = mat[i-1][j];
      |                         ~^~
/src/geos/src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseUtilities.hpp:185:29: note: within this loop
  185 |     for( integer i = ind; i > firstRow; --i )
      |                           ~~^~~~~~~~~~
cc1plus: all warnings being treated as errors

[victorapm]

Thanks, Dick! We could merge this into #4156