Repository navigation
Conversation
…sidual norm The thermal single-phase well residual norm computed a normalizer for the control rows but never added their contribution, so Newton could report convergence while the well rate or BHP target was not met. When a rate-controlled well opened after a shut-in period, a line search could leave it at a fraction of the scheduled rate for the rest of the run, and a restarted run, which rebuilds the well state, followed a different path. Count the control rows as the isothermal kernel does. Fixes #4036
victorapm
requested review from
OmarDuran,
dkachuma,
jhuang2601,
rrsettgast and
tjb-ltk
as code owners
September 28, 2026 17:20
Contributor
|
@victorapm there's another fix PR 4146. |
Contributor
Author
|
Hi Tom, sounds a good idea to me. Feel free to push to this PR! |
…compositional+thermal+wells
jhuang2601
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4036