Skip to content

fix: control equation in the thermal single-phase well residual norm - #4155

Open
victorapm wants to merge 5 commits into
developfrom
fix/paludettomag1/issue-4036
Open

victorapm wants to merge 5 commits into
developfrom
fix/paludettomag1/issue-4036

Conversation

@victorapm

@victorapm victorapm commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor
  1. The thermal single-phase well residual norm computed a normalizer for the control rows but never added their contribution, so Newton could report convergence while the well rate or BHP target was not met. When a rate-controlled well opened after a shut-in period, a line search could leave it at a fraction of the scheduled rate for the rest of the run, and a restarted run, which rebuilds the well state, followed a different path. Count the control rows as the isothermal kernel does.

Fixes #4036

  1. There was an error in the residual scaling for well equations in thermal. This was introduced in the refactor merge. When the well boundary condition is BHP, the wells inactive rate constraint to use for the residual scaling in the component balance equations.

…sidual norm

The thermal single-phase well residual norm computed a normalizer for the
control rows but never added their contribution, so Newton could report
convergence while the well rate or BHP target was not met. When a
rate-controlled well opened after a shut-in period, a line search could
leave it at a fraction of the scheduled rate for the rest of the run, and
a restarted run, which rebuilds the well state, followed a different path.
Count the control rows as the isothermal kernel does.

Fixes #4036
@victorapm victorapm self-assigned this Sep 28, 2026
@victorapm victorapm added flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds labels Sep 28, 2026
@tjb-ltk

tjb-ltk commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@victorapm there's another fix PR 4146.
src/coreComponents/physicsSolvers/fluidFlow/wells/kernels/ThermalCompositionalMultiphaseWellKernels.hpp
What do you think about including in this PR ?

@victorapm

Copy link
Copy Markdown
Contributor Author

Hi Tom, sounds a good idea to me. Feel free to push to this PR!

@tjb-ltk
tjb-ltk requested a review from joshua-white as a code owner October 7, 2026 20:08
@jhuang2601 jhuang2601 added flag: requires rebaseline Requires rebaseline branch in integratedTests and removed flag: no rebaseline Does not require rebaseline labels Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Divergence in execution path upon restart for single phase thermal well simulation

3 participants