Repository navigation
feat: WHP constraint - #3987
Open
tjb-ltk wants to merge 192 commits into
Open
feat: WHP constraint #3987tjb-ltk wants to merge 192 commits into
tjb-ltk wants to merge 192 commits into
Conversation
…aint class hierachy , 3) Remove all old constraint handling methods/variables, 4) it compiles ...
…lephase still needs testing
…t compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml
… to fixed and inputFiles regenerated
…d convert compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml" This reverts commit fa61ab1.
…well initialization vagaries assoiated with useSurfaceConditions=0
tjb-ltk
added
type: feature
tjb-ltk
added
the
flag: requires rebaseline
joshua-white
reviewed
Oct 1, 2026
joshua-white
reviewed
Oct 1, 2026
joshua-white
reviewed
Oct 1, 2026
joshua-white
reviewed
Oct 1, 2026
joshua-white
reviewed
Oct 1, 2026
| m_axisStepInv[i], | ||
| m_axisPoints[i], | ||
| axisLows[i], axisStepInv[i], axisMults[i] ); | ||
| //std::cout << " axis " << i << " index " << axisIndex << " mul " << m_axisHypercubeMults[i] <<std::endl; |
Contributor
There was a problem hiding this comment.
Please do a search through the whole diff for std::cout and similar, unless really needed for future debugging.
joshua-white
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wellhead pressure constraint option