Repository navigation
chore: move to pnpm and Node 24, update toolchain, drop unused deps - #531
Merged
Merged
Conversation
- yarn 4 -> pnpm 10 workspace; resolutions -> pnpm.overrides - link @frigade/js from the workspace like yarn did (linkWorkspacePackages) - CI and release workflows on pnpm and Node 24 (.nvmrc) - version-packages also refreshes pnpm-lock.yaml so frozen installs keep passing - keep npm provenance on release (NPM_CONFIG_PROVENANCE) - TypeScript 5.9, Jest 30, ts-jest 29.4; tsup stays on 6 (8 changed runtime behavior) - remove husky, lint-staged, typedoc, babel (js-api), and other unused devDependencies - declare embla-carousel and eslint-plugin-react-hooks where they are imported - type Card's forwardRef explicitly for TS 5.9
npx doesn't fetch wait-on under pnpm's layout and fails with 'not found'.
eltoncrego
approved these changes
Oct 8, 2026
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the monorepo from yarn 4 to pnpm and from Node 22 to Node 24 for development and CI. The published packages are unchanged for consumers: same entry points, same dependencies and ranges, same runtime output, and type declarations that only differ cosmetically.
What changed
Package manager
packageManager,pnpm-workspace.yaml,pnpm-lock.yaml)resolutions→pnpm.overrides(security pins kept; brace-expansion pins moved to patched versions)linkWorkspacePackages: trueso@frigade/reactbuilds and tests against the local@frigade/js, as yarn did. Published manifests still carry the plain^0.9.12range (checked withpnpm pack)..yarn/,.yarnrc.yml,yarn.lock,.gitattributes(yarn-only) and the stalepackages/react/release-local.shCI and release
pnpm/action-setup+setup-nodewith.nvmrc(Node 24) and the pnpm cachepnpm version-packages, which is nowchangeset version && pnpm install --lockfile-only. Without that, a Version Packages PR would leave the lockfile stale and break--frozen-lockfile.pnpm releasepublishes throughpnpm publish(changesets adds--no-git-checks).NPM_CONFIG_PROVENANCE=trueon the main release keeps the signed provenance the npm CLI was adding. Canary has noid-tokenpermission, so it stays without provenance as before.Toolchain
@types/jest30,@types/node24@frigade/jsbundle enough to break Storybook interaction tests, so it is out of scope here.Cleanup
.husky,preparescript) and unused devDependencies: lint-staged, typedoc + typedoc-plugin-markdown, jest-config, prop-types, cross-fetch, copyfiles, react-test-renderer,@storybook/testing-library,@storybook/cli,@types/dompurify(dompurify ships types), plus the unused babel setup injs-apiembla-carousel(type import),eslint-plugin-react-hooks(used by the react eslint config)Cardnow types itsforwardRefgenerics explicitly, which TS 5.9 needs. The exportedCardComponenttype is unchanged.Verification
pnpm install --frozen-lockfile,pnpm build,pnpm turbo test: pass (js 28 passed / 12 skipped, react 17 passed)test-storybook: 65 passed / 2 skipped, matchingmainmain:.d.tsoutput is equivalent:export { type X }modifiers (needs TS 4.5+ in consumers), andBoxPropsprinted without its default generic argumentpnpm audit: 14 → 10. All remaining advisories are dev-only: the private legacyreactv1Storybook 7 toolchain, transitive deps of@changesets/cliwith no fixed release, and tsup/esbuild.