Repository navigation
Conversation
Local-path marketplaces are registered under their directory name, not the `name` field in marketplace.json. The plugins and enterprise registry docs did not mention this, so following them led to "Marketplace not found" errors on install. Document the naming rule and point to `droid plugin marketplace list` for the exact name. Refs Factory-AI#6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a marketplace is added from a local path, droid registers it under the directory name, not the
namefield inmarketplace.json. The plugins docs and the enterprise plugin registry docs don't say this. Users who follow them and install with<plugin>@<marketplace.json name>hitMarketplace "..." not found.This PR documents the naming rule where local marketplaces are added, and points to
droid plugin marketplace listfor the exact registered name.docs/cli/configuration/plugins.mdx: add a note under "From local path"docs/enterprise/enterprise-plugin-registry.mdx: add the naming rule and a matching install example (security-toolkit@company-plugins)building-plugins.mdxalready says "The folder name becomes the marketplace name", so these pages now agree with it.Notes
This is a docs-only change. Keying the marketplace by the manifest
name, or improving the error message, would have to happen in the CLI.Refs #6