Skip to content

Unify extension email settings and deployment setup - #315

Draft
admdly wants to merge 6 commits into
mainfrom
codex/package-deployment-setup
Draft

admdly wants to merge 6 commits into
mainfrom
codex/package-deployment-setup

Conversation

@admdly

@admdly admdly commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Rename extension email configuration to the provider-neutral EXTENSIONS_EMAIL_* names across both adapters, existing tests, examples, Wrangler configuration and generated bindings. MXroute reads server, username and password; Resend reads the same password setting as its API key. From and Reply-To remain optional shared settings.

Refresh deployment guidance for the trusted-maintainer model, required Preview App credentials, aligned Node versions and the tested local-OAuth artifact deployment for dashboard-related domain-metadata failures.

Validation: formatting, lint, typecheck, all 939 workspace tests and the API dry-run build pass. Existing tests cover both email adapters and moderation notifications with the renamed settings. Two existing generated-runtime lint warnings remain.

Before production deployment, configure EXTENSIONS_EMAIL_SERVER, EXTENSIONS_EMAIL_USERNAME and secret EXTENSIONS_EMAIL_PASSWORD. This PR remains draft until those settings are ready. Production packaging remains disabled.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying Preview to Cloudflare (api)

Preview URL: https://codex-package-deployment-setup-api.fossbilling.workers.dev/ (commit 7daa4e5)

This URL reflects your latest successful Preview deployment.

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) Details
Build: Success ✅
Deployment: Success ✅
https://e3fe153b-api.fossbilling.workers.dev/ 7daa4e5 2026-11-13T02:05:21.107Z View logs ↗
Build: Success ✅
Deployment: Success ✅
https://40cd628c-api.fossbilling.workers.dev/ 8ba0941 2026-11-13T01:39:55.034Z View logs ↗
Build: Success ✅
Deployment: Success ✅
https://8a9a2120-api.fossbilling.workers.dev/ eec1257 2026-11-12T10:44:04.374Z View logs ↗
Build: Success ✅
Deployment: Success ✅
https://54824b1d-api.fossbilling.workers.dev/ 14f4985 2026-11-10T16:51:38.455Z View logs ↗
Build: Success ✅
Deployment: Success ✅
https://7e1759b0-api.fossbilling.workers.dev/ 75c1eb4 2026-11-10T16:08:22.597Z View logs ↗
Build: Success ✅
Deployment: Success ✅
https://ed3f3e62-api.fossbilling.workers.dev/ ff3179a 2026-11-10T14:13:17.772Z View logs ↗

@admdly
admdly marked this pull request as ready for review November 10, 2026 16:07
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-12T10:48:48.190785Z eec1257 Draft marked ready

Security findings

Advisory findings (1)

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Auto-approved: Documentation-only update clarifying deployment token permissions, preview/staging secrets, and frontend transport setup; no code or behavior changes, so the change is bounded and low-risk.

Turn on auto-fix | Re-trigger cubic

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Codex Security Review · Automatically triggered

Here are some automated security review suggestions for this pull request.

Reviewed commit: 75c1eb4a9c

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Comment thread services/api/README.md Resolved
@admdly
admdly marked this pull request as draft November 10, 2026 16:46
cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Nov 10, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Auto-approved: Documentation-only PR adding explanatory workflow comments and expanding README deployment setup guidance. It changes no workflow behavior or security configuration, so the change is bounded and clearly beneficial.

Turn on auto-fix | Re-trigger cubic

@admdly admdly self-assigned this Nov 12, 2026
@admdly
admdly marked this pull request as ready for review November 12, 2026 10:44

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread services/api/README.md Resolved
@cubic-dev-ai
cubic-dev-ai Bot dismissed their stale review November 12, 2026 10:46

Dismissed because Cubic found issues in a newer review.

@admdly
admdly marked this pull request as draft November 13, 2026 01:59
@admdly admdly changed the title Clarify production and preview deployment setup Unify extension email settings and deployment setup Nov 13, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 10 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="services/api/src/services/extensions/v2/email/mxroute.ts">

<violation number="1" location="services/api/src/services/extensions/v2/email/mxroute.ts:25">
P2: Renaming these lookups drops existing dashboard-configured email credentials on the first deployment. `keep_vars` preserves `EXTENSIONS_V2_*` keys, not the new keys, so notifications silently disable. Read the old names as fallbacks or migrate the dashboard variables before deployment.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Turn on auto-fix | Re-trigger cubic

const server = env.getEnv("EXTENSIONS_V2_MXROUTE_SERVER");
const username = env.getEnv("EXTENSIONS_V2_MXROUTE_USERNAME");
const password = env.getEnv("EXTENSIONS_V2_MXROUTE_PASSWORD");
const server = env.getEnv("EXTENSIONS_EMAIL_SERVER");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Renaming these lookups drops existing dashboard-configured email credentials on the first deployment. keep_vars preserves EXTENSIONS_V2_* keys, not the new keys, so notifications silently disable. Read the old names as fallbacks or migrate the dashboard variables before deployment.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At services/api/src/services/extensions/v2/email/mxroute.ts, line 25:

<comment>Renaming these lookups drops existing dashboard-configured email credentials on the first deployment. `keep_vars` preserves `EXTENSIONS_V2_*` keys, not the new keys, so notifications silently disable. Read the old names as fallbacks or migrate the dashboard variables before deployment.</comment>

<file context>
@@ -22,9 +22,9 @@ export function loadMxrouteConfig(
-  const server = env.getEnv("EXTENSIONS_V2_MXROUTE_SERVER");
-  const username = env.getEnv("EXTENSIONS_V2_MXROUTE_USERNAME");
-  const password = env.getEnv("EXTENSIONS_V2_MXROUTE_PASSWORD");
+  const server = env.getEnv("EXTENSIONS_EMAIL_SERVER");
+  const username = env.getEnv("EXTENSIONS_EMAIL_USERNAME");
+  const password = env.getEnv("EXTENSIONS_EMAIL_PASSWORD");
</file context>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant